Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve unique #810

Merged
merged 6 commits into from
Apr 10, 2022
Merged

refactor: improve unique #810

merged 6 commits into from
Apr 10, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Apr 8, 2022 •
edited
Loading

bumped maxTime from 3 to 50 ms because there was a flaky test in #807

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 8, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 8, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #810 (7db2063) into main (a712442) will increase coverage by 0.00%.
The diff coverage is 99.18%.

❗ Current head 7db2063 differs from pull request most recent head 3cfeebf. Consider uploading reports for the commit 3cfeebf to get more accurate results

@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files        1921     1921           
  Lines      179087   179107   +20     
  Branches      907      899    -8     
=======================================
+ Hits       177935   177958   +23     
+ Misses       1096     1093    -3     
  Partials       56       56
Impacted Files Coverage Δ
src/utils/unique.ts 98.62% <98.95%> (+3.38%) ⬆️
src/unique.ts 100.00% <100.00%> (ø)
src/utils/user-agent.ts 97.84% <0.00%> (-0.27%) ⬇️
src/lorem.ts 100.00% <0.00%> (ø)
src/company.ts 100.00% <0.00%> (ø)
src/datatype.ts 100.00% <0.00%> (ø)
src/internet.ts 100.00% <0.00%> (ø)
src/system.ts 96.46% <0.00%> (+0.05%) ⬆️

@Shinigami92 Shinigami92 mentioned this pull request Apr 8, 2022
Merged
@Shinigami92 Shinigami92 marked this pull request as ready for review April 8, 2022 12:43
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 8, 2022 12:43
@Shinigami92 Shinigami92 requested a review from a team April 8, 2022 12:43
ST-DDT
ST-DDT requested changes Apr 8, 2022
View reviewed changes
src/unique.ts Outdated Show resolved Hide resolved
src/unique.ts Outdated Show resolved Hide resolved
src/utils/unique.ts Outdated Show resolved Hide resolved
src/utils/unique.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from ST-DDT and a team April 8, 2022 16:25
@ST-DDT ST-DDT requested a review from a team April 8, 2022 16:32
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 10, 2022 10:02
@Shinigami92 Shinigami92 merged commit 612fc38 into main Apr 10, 2022
@Shinigami92 Shinigami92 deleted the refactor-improve-unique branch April 10, 2022 10:03
@Shinigami92 Shinigami92 mentioned this pull request Apr 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @import-brain