-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic definitions tree #822
Conversation
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1921 1921
Lines 179170 179183 +13
Branches 895 898 +3
=======================================
+ Hits 177993 178006 +13
Misses 1121 1121
Partials 56 56
|
Partially addresses #823 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To really understand what's going on in initDefinitions
I would like to have a screenshare after my vacation with you, where I go through the code and you explain what I don't understand 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out locally with the new tests but without the changes in src
To me this is not a feature but a bugfix!
Instead of making only our definitions/locale data accessible via
faker.definitions
, this PR allows devs to access any data, that are added to the locale itself.Or in other words:
Previously
faker.definitions.business
returnedundefined
even thoughfaker.locales.en.buisness
is defined.