Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internet): HTTP random status code #945

Merged
merged 18 commits into from
May 21, 2022
Merged

Conversation

johge201
Copy link
Contributor

Hi!
This is our first commit to an open-source project.
This feature adds some random status codes, with testing included.

Feel free to give us some feedback :)

Link to issue: issue 906

@johge201 johge201 requested a review from a team as a code owner May 11, 2022 14:31
@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent labels May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #945 (0783d1b) into main (b0cdf29) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files        1970     1971       +1     
  Lines      210012   210061      +49     
  Branches      887      887              
==========================================
+ Hits       209312   209354      +42     
- Misses        681      688       +7     
  Partials       19       19              
Impacted Files Coverage Δ
src/definitions/internet.ts 0.00% <0.00%> (ø)
src/locales/en/internet/http_status_code.ts 100.00% <100.00%> (ø)
src/locales/en/internet/index.ts 100.00% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️

@xDivisionByZerox xDivisionByZerox linked an issue May 11, 2022 that may be closed by this pull request
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone May 11, 2022
src/definitions/internet.ts Outdated Show resolved Hide resolved
@xDivisionByZerox
Copy link
Member

About my comment. Please wait with the implementation change until at least one other member proposed their opinion on this.
Otherwise, this looks clean to me. Thanks for contributing.

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Count as approved after additional requested test was added 👍

test/internet.spec.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented May 12, 2022

Docs-Preview (Click to expand)

grafik

@ST-DDT ST-DDT requested review from a team May 12, 2022 12:45
src/modules/internet/index.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes May 12, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@sofbe sofbe dismissed stale reviews from Shinigami92 and xDivisionByZerox via 287aac6 May 12, 2022 12:52
Shinigami92
Shinigami92 previously approved these changes May 12, 2022
@johge201 johge201 dismissed stale reviews from Minozzzi, import-brain, and Shinigami92 via 4bc3ebc May 18, 2022 06:11
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 18, 2022
ST-DDT
ST-DDT previously approved these changes May 18, 2022
Shinigami92
Shinigami92 previously approved these changes May 18, 2022
@Shinigami92
Copy link
Member

@pkuczynski You may need to approve or comment if you want further changes

src/locales/ro/address/index.ts Outdated Show resolved Hide resolved
src/modules/internet/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed stale reviews from ST-DDT and themself via c36155c May 18, 2022 19:28
Co-authored-by: Piotr Kuczynski <piotr.kuczynski@gmail.com>
@Shinigami92 Shinigami92 requested a review from pkuczynski May 18, 2022 19:32
@Shinigami92 Shinigami92 merged commit 05f555b into faker-js:main May 21, 2022
@xDivisionByZerox xDivisionByZerox added the m: internet Something is referring to the internet module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Random status code
8 participants