Skip to content

Commit

Permalink
Update RuboCop to 0.56.0 (#1227)
Browse files Browse the repository at this point in the history
Also fixes new offenses
  • Loading branch information
tagliala authored and vbrazo committed May 20, 2018
1 parent 8069b50 commit 90f796b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ GEM
powerpack (0.1.1)
rainbow (3.0.0)
rake (12.3.0)
rubocop (0.55.0)
rubocop (0.56.0)
parallel (~> 1.10)
parser (>= 2.5)
powerpack (~> 0.1)
Expand Down
2 changes: 1 addition & 1 deletion lib/faker/star_wars.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def quote(character = nil)
character = k.to_s if v.include?(character)
end

unless quoted_characters.keys.include?(character.to_sym)
unless quoted_characters.key?(character.to_sym)
raise ArgumentError, "Character for quotes can be left blank or #{quoted_characters.keys.join(', ')}"
end
end
Expand Down
4 changes: 2 additions & 2 deletions lib/helpers/unique_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def initialize(generator, max_retries)
@previous_results = Hash.new { |hash, key| hash[key] = Set.new }
end

# rubocop:disable Style/MethodMissing
# rubocop:disable Style/MethodMissingSuper
def method_missing(name, *arguments)
@max_retries.times do
result = @generator.public_send(name, *arguments)
Expand All @@ -19,7 +19,7 @@ def method_missing(name, *arguments)

raise RetryLimitExceeded
end
# rubocop:enable Style/MethodMissing
# rubocop:enable Style/MethodMissingSuper

def respond_to_missing?(method_name, include_private = false)
method_name.to_s.start_with?('faker_') || super
Expand Down

0 comments on commit 90f796b

Please sign in to comment.