-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds domain option for Internet email and domain_name methods (#1808)
* Adds domain option for Internet.email and Internet.domain_name methods * Renames variable to avoid violating rubocop * Adds documentation to modified Internet.email and Internet.domain methods
- Loading branch information
1 parent
84be501
commit dd13a53
Showing
3 changed files
with
20 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd13a53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiagofsilva thank you for this !
Is there a reason you didn't implement it with
domain_suffix
?Or you ignoring it when provided ?
No blaming here, I am just asking
gives me
something_uniq@my_domaincom.some_random_internet_suffix