The examples for Faker::Date.between do not work

[uchagani]

Describe the bug

The examples for Faker::Date.between(from: 2.days.ago, to: Date.today) and Faker::Date.between_except(from: 1.year.ago, to: 1.year.from_now, excepted: Date.today) do not work.

[9] pry(main)> Faker::Date.between(from: 2.days.ago, to: Date.today)
NoMethodError: undefined method `days' for 2:Integer
from (pry):9:in `<main>'

To Reproduce

# Gemfile
source 'https://rubygems.org
gem 'faker'

# test.rb
require 'faker'

date_between = Faker::Date.between(from: 2.days.ago, to: Date.today)

puts date_between.to_s

Expected behavior

I should see a date between the given arguments passed to between

Additional context

My guess is that these examples require activesupport in order to get the extensions on the integer class.

[danielTiringer]

The methods (.days ago and alike) are part of activesupport. Requiring active_support/time makes the example above work.
Should this be mentioned in the documentation (YARD and /docs) as a solution, or should we investigate alternative solutions?

[uchagani]

The documents need to be more explicit in my opinion. Either explaining the dependency or with a more appropriate example.

…

On Sun, Jun 14, 2020 at 3:18 AM Daniel Tiringer ***@***.***> wrote: The methods (.days ago and alike) are part of activesupport. Requiring active_support/time makes the example above work. Should this be mentioned in the documentation (YARD and /docs) as a solution, or should we investigate alternative solutions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2056 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIBHEBK5AZALT4FLK4RPC3RWR2VFANCNFSM4N4UJJLA> .

[Zeragamba]

I think it would be good to update the examples to show both a Rails and Rails-less.

[koic]

The issue has been resolved by #2061.