Fix flaky spec on TestFakerFile#test_file_name

[thdaraujo]

Describe the bug

There is a flaky spec on

faker/test/faker/default/test_faker_file.rb

Line 24 in 391da60

def test_file_name

===============================================================================
Failure: test_file_name(TestFakerFile):
  </^([a-z\-_.]+)(\\|\/)([a-z\-_]+)\.([a-z]+)$/> was expected to be =~
  <"whole-bless/cupiditate.mp3">.
/home/runner/work/faker/faker/test/faker/default/test_faker_file.rb:25:in `test_file_name'
     22:   end
     23: 
     24:   def test_file_name
  => 25:     assert_match %r{^([a-z\-_.]+)(\\|/)([a-z\-_]+)\.([a-z]+)$}, @tester
     26:       .file_name
     27:   end
     28: 
===============================================================================

Failed run

Maybe caused by the latest Rubocop version bump?
#2864

[keshavbiswa]

I'd like to give this a shot 🤚

[thdaraujo]

sounds good, thank you @keshavbiswa !

[keshavbiswa]

This seems like an issue with regexp_parser version bump.

It for some reason matches everystring but "whole-bless/cupiditate.mp3".

matcher = %r{^([a-z\-_.]+)(\\|/)([a-z\-_]+)\.([a-z]+)$}
matcher = Regexp.new Regexp.escape matcher if String === matcher

obj= "cutting-minister/qui.numbers"
matcher =~ obj

Regexp.last_match # => #<MatchData "cutting-minister/qui.numbers" 1:"cutting-minister" 2:"/" 3:"qui" 4:"numbers">

obj = "appointment-notebook/occaecati.bmp"
matcher =~ obj
Regexp.last_match # => #<MatchData "appointment-notebook/occaecati.bmp" 1:"appointment-notebook" 2:"/" 3:"occaecati" 4:"bmp">

# For some reason this doesn't work
obj = "whole-bless/cupiditate.mp3"
matcher =~ obj
Regexp.last_match # => Returns nil

I'm not a Regex expert, could someone help me understand what is the problem here?

[keshavbiswa]

I think I got it, it's not matching the number (.mp3) as the extension. So updating the last part in the regex to assert for alphanumeric should do the job.

[keshavbiswa]

This works!

[thdaraujo]

yep, you got it! Thanks!