Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests warning #1173

Merged
merged 3 commits into from
May 12, 2018
Merged

Fix tests warning #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7431989
Remove unused test variables
vbrazo Mar 27, 2018
5acc62b
Fix ElderScrolls duplicated method and add missing tests
vbrazo Mar 28, 2018
d73de4b
Fix duplicated test class names
vbrazo Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/faker/elder_scrolls.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ def first_name
fetch('elder_scrolls.first_name')
end

def first_name
def last_name
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing duplicated methods. Copy and 🍝 and adding specs for the new methods 👍

fetch('elder_scrolls.last_name')
end

end
end
end
7 changes: 7 additions & 0 deletions test/test_faker_elder_scrolls.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,11 @@ def test_name
assert @tester.name.match(/\w+/)
end

def test_first_name
assert @tester.first_name.match(/\w+/)
end

def test_last_name
assert @tester.last_name.match(/\w+/)
end
end
6 changes: 1 addition & 5 deletions test/test_faker_omniauth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ def test_omniauth_google_with_name
auth = @tester.google(name: custom_name)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]
id_info = auth[:id_info]


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variables are not being used. Why are we still declaring them? Copy and 🍝 again?

assert_instance_of String, info[:name]
assert_equal 2, word_count(info[:name])
assert_equal custom_name, info[:name]
Expand Down Expand Up @@ -184,7 +183,6 @@ def test_omniauth_facebook_with_email
def test_omniauth_facebook_with_uid
custom_uid = '12345'
auth = @tester.facebook(uid: custom_uid)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down Expand Up @@ -286,7 +284,6 @@ def test_omniauth_twitter_with_nickname
def test_omniauth_twitter_with_uid
custom_uid = '12345'
auth = @tester.twitter(uid: custom_uid)
info = auth[:info]
raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down Expand Up @@ -465,7 +462,6 @@ def test_omniauth_github_with_email
def test_omniauth_github_with_uid
custom_uid = '12345'
auth = @tester.github(uid: custom_uid)
info = auth[:info]
extra_raw_info = auth[:extra][:raw_info]

assert_instance_of String, auth[:uid]
Expand Down
2 changes: 1 addition & 1 deletion test/test_zh_locale.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')

class TestZhCnLocale < Test::Unit::TestCase
class TestZhLocale < Test::Unit::TestCase
Copy link
Member Author

@vbrazo vbrazo Mar 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the name of this file. Definitely copy and 🍝

def setup
Faker::Config.locale = 'zh-CN'
end
Expand Down