Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1198 and add deprecation warnings #1284

Closed
wants to merge 3 commits into from
Closed

Revert #1198 and add deprecation warnings #1284

wants to merge 3 commits into from

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Jun 14, 2018 •
edited
Loading

Reference: #1277
Revert: #1198

  • Revert wrong changes
  • Add deprecation warnings

@vbrazo vbrazo self-assigned this Jun 14, 2018
@stympy
Copy link
Contributor

stympy commented Jun 14, 2018

Because of the severity of #1116, I think it's fine to leave #1198 in the upcoming release without going through the deprecation step first. We just need to call it out in the release notes/changelog.

@vbrazo
Copy link
Member Author

vbrazo commented Jun 14, 2018

I see your point. No problem @stympy

@vbrazo vbrazo closed this Jun 14, 2018
@vbrazo vbrazo deleted the fixes/revert-changes-and-deprecate-methods branch June 14, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbrazo vbrazo

Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrazo @stympy