Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Seinfeld.business #1366

Merged
merged 4 commits into from
Sep 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- [PR #1329](https://github.com/stympy/faker/pull/1329) Update docs on behavior of price [@softwaregravy](https://github.com/softwaregravy)

### Feature Request
- [PR #1366](https://github.com/stympy/faker/pull/1366) Add Faker::Seinfeld.business [@dsgraham](https://github.com/dsgraham)
- [PR #1358](https://github.com/stympy/faker/pull/1358) Add cat breed for Japanese [@yizknn](https://github.com/yizknn)
- [PR #1365](https://github.com/stympy/faker/pull/1365) Add Faker::Number.within [@QuantumWaver](https://github.com/QuantumWaver)
- [PR #1336](https://github.com/stympy/faker/pull/1336) Implements and tests South African business registration numbers [@bradleymarques](https://github.com/bradleymarques)
Expand Down
1 change: 1 addition & 0 deletions doc/seinfeld.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ Faker::Seinfeld.character #=> George Costanza

Faker::Seinfeld.quote #=> I'm not a lesbian. I hate men, but I'm not a lesbian

Faker::Seinfeld.business #=> Kruger Industrial Smoothing
```
4 changes: 4 additions & 0 deletions lib/faker/seinfeld.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
module Faker
class Seinfeld < Base
class << self
def business
fetch('seinfeld.business')
end

def character
fetch('seinfeld.character')
end
Expand Down
3 changes: 2 additions & 1 deletion lib/locales/en/seinfeld.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
en:
faker:
seinfeld:
character: ["George Costanza", "Kramer", "Elaine Benes", "Newman", "Jerry Seinfeld", "Frank Costanza", "Morty Seinfeld", "Estelle Costanza", "Susan Ross", "Helen Seinfeld", "J Peterman", "Uncle Leo", "David Puddy", "Justin Pitt", "Kenny Bania", "Crazy Joe Davola", "Jackie Chiles", "Jack Klompus", "Ruthie Cohen", "Tim Whatley", "Sue Ellen", "Bob Sacamano", "Babs Kramer", "Babu Bhatt", "George Steinbrenner", "Mickey Abbott", "Mr. Lippman", "Mr. Wilhelm", "Russell Dalrymple"]
character: ["George Costanza", "Kramer", "Elaine Benes", "Newman", "Jerry Seinfeld", "Frank Costanza", "Morty Seinfeld", "Estelle Costanza", "Susan Ross", "Helen Seinfeld", "J Peterman", "Uncle Leo", "David Puddy", "Justin Pitt", "Kenny Bania", "Crazy Joe Davola", "Jackie Chiles", "Jack Klompus", "Ruthie Cohen", "Tim Whatley", "Sue Ellen Mischke", "Bob Sacamano", "Babs Kramer", "Babu Bhatt", "George Steinbrenner", "Mickey Abbott", "Mr. Lippman", "Mr. Wilhelm", "Russell Dalrymple"]
quote: ["I'm not a lesbian. I hate men, but I'm not a lesbian.", "You're gonna over-dry your laundry.", "This isn't a good time.", "That’s the true spirit of Christmas; people being helped by people other than me.", "You’re becoming one of the glitterati.", "Father, I’ve never done this before, so I’m not sure about what I’m supposed to do.", "She’s one of those low-talkers. You can’t hear a word she’s saying!", "Why do they make the condom packets so hard to open?", "This woman hates me so much, I’m starting to like her.", "I've driven women to lesbianism before, but never a mental institution.", "You know I always wanted to pretend I was an architect", "Borrowing money from a friend is like having sex. It just completely changes the relationship.", "When you look annoyed all the time, people think that you're busy.", "I spend so much time trying to get their clothes off, I never thought of taking mine off.", "If you can't say something bad about a relationship, you shouldn't say anything at all.", "I need the secure packaging of Jockeys. My boys needs a house!", "The sea was angry that day, my friends, like an old man trying to send back soup in a deli...", "Elaine, breaking up is like knocking over a Coke machine. You can’t do it in one push; you gotta rock it back and forth a few times and then it goes over.", "Looking at cleavage is like looking at the sun. You don't stare at it. It's too risky. Ya get a sense of it and then you look away.", "You have the chicken, the hen, and the rooster. The chicken goes with the hen... So who is having sex with the rooster?", "I lie every second of the day. My whole life is a sham.", "Just remember, when you control the mail, you control... information.", "I don't think I've ever been to an appointment in my life where I wanted the other guy to show up.", "You, my friend, have crossed the line between man and bum.", "You should've seen her face. It was the exact same look my father gave me when I told him I wanted to be a ventriloquist.", "Did you know that the original title for War and Peace was War, What Is It Good For?", "Sex, that’s meaningless, I can understand that, but dinner; that’s heavy. That’s like an hour.", "Jerry, just remember, it's not a lie if you believe it.", "These pretzels are makin' me thirsty.", "It became very clear to me sitting out there today that every decision I've made in my entire life has been wrong. My life is the complete opposite of everything I want it to be. Every instinct I have, in every aspect of life, be it something to wear, something to eat - it's all been wrong.", "I had a dream last night that a hamburger was eating me.", "I have been performing feats of strength all morning.", "Hi, my name is George, I'm unemployed and I live with my parents.", "I don't trust the guy. I think he regifted, then he degifted, and now he's using an upstairs invite as a springboard to a Super bowl sex romp.", "Yes, I hope my parents die long before I do.", "See, this is what the holidays are all about. Three buddies sitting around chewing gum.", "Dolores!", "I'll be back. We'll make out.", "I'm sorry to bother you, but I'm a US postal worker and my mail truck was just ambushed by a band of backwoods mail-hating survivalists.", "You very bad man, Jerry. Very bad man.", "No soup for you!", "Serenity now!", "I'm out there Jerry, and I'm loving every minute of it!", "I'm out of the contest!", "You're killing independent George!", "Not that there's anything wrong with that.", "Yadda, yadda, yadda.", "They're real, and they're spectacular.", "She has man hands.", "And you want to be my latex salesman.", "He's a close talker.", "It's a Festivus for the rest of us.", "I want to be the one person who doesn't die with dignity.", "You, my friend, have crossed the line between man and bum.", "You were necking during Schindler's List?"]
business: ["Champagne Video", "Joe's Fruit Shop", "Kruger Industrial Smoothing", "Vandelay Industries", "Kramerica Industries", "J. Peterman Catalog", "Tom's Restaurant", "Reggies", "Mendy's", "Sunshine Carpet Cleaners", "Brandt-Leland", "H and H Bagels", "Play Now", "Top of the Muffin to You!", "Oh Henry!", "P B and J's", "Poppie's", "Sagman, Bennett, Robbins, Oppenheim and Taft", "Pendant Publishing", "Dream Cafe", "Doubleday", "Tyler Chicken", "Royal Bakery"]
4 changes: 4 additions & 0 deletions test/test_faker_seinfeld.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,8 @@ def test_character
def test_quote
assert @tester.quote.match(/\w+/)
end

def test_business
assert @tester.quote.match(/\w+/)
end
end