Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1416

Closed
wants to merge 1 commit into from
Closed

Update README.md #1416

wants to merge 1 commit into from

Conversation

cjmz
Copy link

@cjmz cjmz commented Oct 16, 2018

I think we can detach the most common items to provide an easy way to find it.

When I use it, normally I waste time searching an item that is common (like a Faker::Name).

Y'all can say if is this a good idea?

I think we can detach the most common items to provide an easy way to find it.

When I use it, normally I waste time searching an item that is common (like a Faker::Name).

Y'all can say if is this a good idea?
@stympy
Copy link
Contributor

stympy commented Oct 16, 2018

I'm not in love with this idea, as it sets up the possibility of an eternal discussion about what is common. :) I don't want to merge this right away, nor do I want to close it right away; rather, I'd like to take some time to ponder this change. Other input is welcome!

@cjmz
Copy link
Author

cjmz commented Oct 16, 2018

I understand, maybe it will be a huge discussion. I was intended to separate items like:

  • Booleans
  • Numbers and Dates
  • Strings (Lorem and Name)

Perhaps images URL, as Faker::Avatar is an usual pick in a CRUD.

@vbrazo
Copy link
Member

vbrazo commented Oct 16, 2018

@cjmz we're trying to separate items by defining namespaces in this issue #1318. Check it out.

@cjmz
Copy link
Author

cjmz commented Oct 16, 2018

@vbrazo Great! I'm sure that namespaces will solve this problem too. Possibly this PR be just a moment solution, so not a consistent solution.

I see that namespaces like a great idea and I'll try to help!

Maybe is a good idea to close here.

@vbrazo vbrazo closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants