Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating Faker::Bank#routing_number #1563

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

psienko
Copy link
Contributor

@psienko psienko commented Mar 5, 2019

This PR fixes #1561

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement

Changes look good to me

@vbrazo vbrazo force-pushed the master branch 3 times, most recently from 69291b2 to 5cc660c Compare July 5, 2019 17:21
@vbrazo vbrazo force-pushed the master branch 3 times, most recently from a2a9f17 to 4384168 Compare September 30, 2019 07:10
@manishdas
Copy link

manishdas commented Nov 24, 2019

I'd really appreciate you guys merging this PR and releasing the fix. We are still running into this error frequently. Let me know if I can be of any help.

@vbrazo vbrazo merged commit eaaeaf1 into faker-ruby:master Nov 24, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faker::Bank.routing_number sometimes generates routing number with wrong checksum
4 participants