Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FillMurray Links To Include www #1660

Merged
merged 5 commits into from
Jul 24, 2019
Merged

Update FillMurray Links To Include www #1660

merged 5 commits into from
Jul 24, 2019

Conversation

RaymondFallon
Copy link
Contributor

@RaymondFallon RaymondFallon commented Jul 19, 2019 •
edited by vbrazo
Loading

Fixes #1659 #1651

FillMurray links now need www in the URL. This PR adds that and updates tests + documentation.

@vbrazo vbrazo added the v2 label Jul 23, 2019
@vbrazo vbrazo changed the base branch from master to v2 July 23, 2019 04:06
bpleslie
bpleslie approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice cleanup on https://github.com/stympy/faker/pull/1660/files#diff-39e7361308983b59815fc6ff150b7947R11

@RaymondFallon
Copy link
Contributor Author

Looks good to me! Nice cleanup on https://github.com/stympy/faker/pull/1660/files#diff-39e7361308983b59815fc6ff150b7947R11

Thanks! 😊

@vbrazo
Copy link
Member

vbrazo commented Jul 23, 2019

@RaymondFallon could you fix the merge issues with our v2 branch?

@RaymondFallon
Copy link
Contributor Author

@vbrazo OK, the conflict is resolved. It is now failing CI, but it looks like that is a broader issue with stympy:v2. Is that correct?

@vbrazo
Copy link
Member

vbrazo commented Jul 24, 2019 •
edited
Loading

True! I just made the decimal_part return string temporarily. We still need to convert decimal_part and decimal to double instead of string.

Merging now! Thanks for fixing the urls!

@vbrazo vbrazo merged commit 748adef into faker-ruby:v2 Jul 24, 2019
@RaymondFallon
Copy link
Contributor Author

My pleasure, thanks for maintaining this awesome app!

@vbrazo vbrazo mentioned this pull request Jul 24, 2019
Merged
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@RaymondFallon @michebble
Update FillMurray Links To Include www (faker-ruby#1660)
c01ecf0 
* Update FillMurray Links To Include www

* Faker::Number.decimal_part should return string for now
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@RaymondFallon @vbrazo
Update FillMurray Links To Include www (faker-ruby#1660)
010b5ee 
* Update FillMurray Links To Include www

* Faker::Number.decimal_part should return string for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpleslie bpleslie bpleslie approved these changes

@vbrazo vbrazo vbrazo approved these changes

Assignees

@RaymondFallon RaymondFallon

Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaymondFallon @vbrazo @bpleslie