Add Bibles class with King James subclass #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
approved these changes
Aug 20, 2019
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
|
Thanks! |
Zeragamba
added a commit
that referenced
this pull request
May 18, 2020
This reverts commit 800855f.
Zeragamba
added a commit
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1641
Description:
After viewing issue #1641, I thought I'd take a stab at adding a Bible class to Faker. In my branch, I initially included
Bibleas a subclass ofBooks, but I thought that makingBiblesits own class might make it more extensible should anyone want to add other versions.The yaml file is quite large but I've attempted to keep read times down by only accessing one book at a time.
I've included the King James English version, but there are several others that might eventually be included in the class. All tests and checks passing locally.