Fix number(digits: 1) always returns 0 #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlet
force-pushed
the
fix_number_returns_only_0
branch
from
ed13962
to
e968744
Compare
Zeragamba
approved these changes
Aug 29, 2019
lucasqueiroz
approved these changes
Aug 30, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Fix number(digits: 1) always returns 0 Fixes faker-ruby#1705 * remove unnecessary Base
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Fix number(digits: 1) always returns 0 Fixes faker-ruby#1705 * remove unnecessary Base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1705
Note: Fixing
numberwith one digit caused thetest_insignificant_zeroto fail. As it seemed that the behavior tested bytest_insignificant_zerowas already covered bytest_numberandtest_decimal, I removed it to prevent duplication.