Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pokemon name in Johto area #1723

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

Ryutooooo
Copy link
Contributor

I'm using Faker::Games::Pokemon on my Rails project.
but sometimes, my rspec is failed by uniqueness some String column.
so I need more pokemon name, I added Johto pokemons.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 6707946 into faker-ruby:master Sep 10, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* first commit

* doc: added pokemon names Johto area
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* first commit

* doc: added pokemon names Johto area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants