add only japanese word spec #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4geru
commented
Sep 17, 2019
| @@ -12,8 +12,8 @@ ja: | |||
| - "#{city_prefix}#{Name.last_name}#{city_suffix}" | |||
| - "#{Name.last_name}#{city_suffix}" | |||
| street_name: | |||
| - "#{Name.first_name}#{street_suffix}" | |||
There was a problem hiding this comment.
Jpananese address not have street_suffix in first_name and street_suffix.
4geru
commented
Sep 17, 2019
| assert Faker::Name.name_with_middle.is_a? String | ||
| assert Faker::Name.female_first_name.is_a? String |
There was a problem hiding this comment.
there is not written original Japanese I18n.
4geru
force-pushed
the
add_only_japanese_spec
branch
from
f6d2c11 to
5739c85
Compare
bpleslie
approved these changes
Sep 19, 2019
4geru
force-pushed
the
add_only_japanese_spec
branch
from
47c76f2 to
4ef89ad
Compare
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* add only japanese word spec * add assert_not_english method
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add only japanese word spec * add assert_not_english method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there expect translate in Japanese.
Japanese use only Kana words without alphabets.
but there is no any test. so I add test.