Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.4.0 #1754

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Bump version to 2.4.0 #1754

merged 3 commits into from
Sep 19, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Sep 19, 2019

Bump version to 2.4.0 to introduce Faker::Blockchain::Aeternity generator.

2.4.0 also fixes several locales and documentation.

Copy link
Member

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to replace the @faker.version next YARD tags

Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@vbrazo
Copy link
Member Author

vbrazo commented Sep 19, 2019

@Zeragamba I did a search and wasn't able to find them, so I guess they were already fixed!

@Zeragamba
Copy link
Contributor

Oh. I thought i saw a few. Carry on.

@vbrazo vbrazo merged commit 68207d5 into master Sep 19, 2019
@vbrazo vbrazo deleted the bump-version-to-2-4-0 branch September 19, 2019 23:24
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Bump version to 2.4.0

* Faker::VERSION to 2.4.0

* Update CHANGELOG.md

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Bump version to 2.4.0

* Faker::VERSION to 2.4.0

* Update CHANGELOG.md

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants