Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more prefixes and suffixes to Name #1792

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Add more prefixes and suffixes to Name #1792

merged 2 commits into from
Jun 10, 2020

Conversation

mathisto
Copy link
Contributor

@mathisto mathisto commented Oct 4, 2019

Issue#

No-Story

Description:

This PR simply adds a handful of additional entries to the available prefixes and suffixes in the default Name class. Data gathered from these sources:

  1. https://departments.weber.edu/qsupport&training/Data_Standards/Name.htm
  2. https://mediawiki.middlebury.edu/LIS/Name_Standards

@mathisto mathisto changed the title Improve names prefix and suffix lists Add more prefixes and suffixes to Name Oct 4, 2019
bpleslie
bpleslie approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for contributing!

@Zeragamba Zeragamba merged commit 20af4e3 into faker-ruby:master Jun 10, 2020
@Zeragamba
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpleslie bpleslie bpleslie approved these changes

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathisto @Zeragamba @bpleslie @vbrazo