add Faker::Relationship YARD docs #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@connorshea is this PR already created before? |
connorshea
reviewed
Oct 8, 2019
connorshea
reviewed
Oct 8, 2019
lib/faker/default/relationship.rb
Outdated
| @@ -26,18 +35,54 @@ def familial(legacy_connection = NOT_GIVEN, connection: nil) | |||
| fetch('relationship.familial.' + connection) | |||
| end | |||
|
|
|||
| ## | |||
| # Produces a random in-law relationship . | |||
There was a problem hiding this comment.
Suggested change
| # Produces a random in-law relationship . | |
| # Produces a random in-law relationship. |
|
@ashishra0 nope, it hasn't been done yet. If it isn't checked off and/or doesn't have a PR reference in #1762 then it hasn't been done. |
Closed
|
@connorshea Just wanted to be sure :) |
add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
connorshea
approved these changes
Nov 13, 2019
vbrazo
approved these changes
Nov 13, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* add Faker::Relationship YARD docs * Update lib/faker/default/relationship.rb add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * add Faker::Relationship YARD docs * Update lib/faker/default/relationship.rb add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * add faker version as 1.9.2 * remove trailing whitespace
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add Faker::Relationship YARD docs * Update lib/faker/default/relationship.rb add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * add Faker::Relationship YARD docs * Update lib/faker/default/relationship.rb add version 1.9.2 Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * add faker version as 1.9.2 * remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete YARD docs for Faker::Relationship YARD docs