Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding chilean_id in Faker::IDNumber #1819

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Conversation

cristofer
Copy link
Contributor

Description:

This PR adds the Faker::IDNumber.chilean_id

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the Chilean RUT and your proposed feature?

@cristofer
Copy link
Contributor Author

@vbrazo when looking for Faker IDs I realised this should be included in IDNumber, as the case for the spanish and the brazilian. This IDNumber.chilean_id aims to just give any rut with 8 digits plus the verification difgit. Also it uses the concept of RUT as the complete sequence, not full_rut or rut and digit.

doc/default/id_number.md Outdated Show resolved Hide resolved
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit 7c649e8 into faker-ruby:master Nov 2, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Adding chilean_id in Faker::IDNumber

* Referring to Faker::ChileRut in the id_number documentation
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Adding chilean_id in Faker::IDNumber

* Referring to Faker::ChileRut in the id_number documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants