Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add domain_suffix option to internet .email and .domain_name #1855

Closed

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Dec 5, 2019

Issue#

#1845

Description:

Clean and Fix the Internet.domain_name and Internet.email api as seen with @tiagofsilva

@ngouy ngouy force-pushed the internet-add-domain-suffix-option branch from d8502c4 to 8bd9259 Compare December 5, 2019 22:48
@ngouy ngouy force-pushed the internet-add-domain-suffix-option branch from 8bd9259 to 9f1ef94 Compare February 5, 2020 19:11
@Zeragamba
Copy link
Contributor

I find domain_suffix to be a bit confusing and verbose to me. What about just tld?

@ngouy
Copy link
Contributor Author

ngouy commented Feb 5, 2020

I have to confess that I had to google it to find out that tld the abbreviation for top-level-domain (boooo what a shame ^^, not sure you should accept a PR from this guy).
In general, I feel like using abbreviations can sometimes be inconvenient for others not as comfortable as us about some domains.

Though I agree that domain_suffix is verbose (and can easily be confusing too)

@Zeragamba
Copy link
Contributor

Testing locally, I noticed that the root issue (periods being stripped from the domain name) was resolved at some point:

irb(main):002:0> require 'faker'
=> true
irb(main):003:0> Faker::VERSION
=> "2.10.1"
irb(main):004:0> Faker::Internet.email(domain: "example.gov.uk")
=> "fredrick@example.gov.uk"

I don't think this PR is needed anymore.

@ngouy
Copy link
Contributor Author

ngouy commented Feb 11, 2020

I close this for now until @tiagofsilva want to discuss about it sometimes

@ngouy ngouy closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants