Fix tests failing on Ruby 2.7 #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were failing because the error being raised has changed.
connorshea
force-pushed
the
fix-tests-failing-2-7
branch
from
f8e16fe to
3f8a2d8
Compare
|
Hmm, weird. Did Bundler 2.1.1 break something? 🤔 |
connorshea
added a commit
to connorshea/docs-travis-ci-com
that referenced
this pull request
Dec 18, 2019
I discovered this was necessary after upgrading to Bundler 2.1.0 yesterday, only for CI to break when 2.1.1 came out today. See also: faker-ruby/faker#1867
This was referenced Dec 18, 2019
Merged
Pezi777
added a commit
to travis-ci/docs-travis-ci-com
that referenced
this pull request
Dec 19, 2019
* Update 'Building Ruby' docs with another fix for Bundler 2.0 I discovered this was necessary after upgrading to Bundler 2.1.0 yesterday, only for CI to break when 2.1.1 came out today. See also: faker-ruby/faker#1867 * Apply suggestions from code review Co-Authored-By: Petra <52408528+Pezi777@users.noreply.github.com>
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Fix two tests that are failing on Ruby 2.7. These were failing because the error being raised has changed. * Switch bundler version to 2.1.0 in CI. * Try updating RubyGems before Bundler. * Force accept the gem update --system confirmation.
gitandhub1
pushed a commit
to gitandhub1/docs-travis-ci-com
that referenced
this pull request
Jun 5, 2020
…ci#2613) * Update 'Building Ruby' docs with another fix for Bundler 2.0 I discovered this was necessary after upgrading to Bundler 2.1.0 yesterday, only for CI to break when 2.1.1 came out today. See also: faker-ruby/faker#1867 * Apply suggestions from code review Co-Authored-By: Petra <52408528+Pezi777@users.noreply.github.com>
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Fix two tests that are failing on Ruby 2.7. These were failing because the error being raised has changed. * Switch bundler version to 2.1.0 in CI. * Try updating RubyGems before Bundler. * Force accept the gem update --system confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft because it depends on #1866. Once that's merged, I'll rebase this PR and this PR can be merged.
These were failing because the error being raised has changed. I'm not sure if this is the best way to solve this problem, I'm open to feedback.