Locale root name should be en-NEP #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the existing convention name followed in the library: The file name and the root key should be same.
|
I guess the test failure is because the locale name is assumed as "nep". I don't have strong opinion eitherwise. But I feel we should follow the existing convention of using the file name and root yaml key as same. So, probably we can change the file name to "nep.yml" instead of "en-NEP.yml". Any thoughts on this ? |
vbrazo
approved these changes
Jan 13, 2020
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Locale root name should be en-NEP Follow the existing convention name followed in the library: The file name and the root key should be same. * Fix test failure
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Locale root name should be en-NEP Follow the existing convention name followed in the library: The file name and the root key should be same. * Fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the existing convention name followed in the library: The file
name and the root key should be same.