Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD docs for Faker::DcComics #1913

Merged
merged 7 commits into from
Feb 15, 2020
Merged

Add YARD docs for Faker::DcComics #1913

merged 7 commits into from
Feb 15, 2020

Conversation

ashelangovan
Copy link

Part of #1762.

Aswin Muthu Kumar added 2 commits January 17, 2020 09:35
Add YARD docs for Faker::DcComics
94f5924 
Signed-off-by: Aswin Muthu Kumar <ashelangovan97@gmail.com>
Minor doc update
bbaab80 
Signed-off-by: Aswin Muthu Kumar <ashelangovan97@gmail.com>
@ashelangovan ashelangovan requested a review from vbrazo January 17, 2020 04:16
@ashelangovan
Copy link
Author

ashelangovan commented Jan 17, 2020 •
edited
Loading

@vbrazo As only Faker::DcComics is present, I think adding Faker::Marvel would be nice. Any thoughts?

@connorshea connorshea mentioned this pull request Feb 14, 2020
Closed
connorshea
connorshea requested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor grammatical changes, otherwise LGTM

lib/faker/default/dc_comics.rb Outdated Show resolved Hide resolved
lib/faker/default/dc_comics.rb Outdated Show resolved Hide resolved
lib/faker/default/dc_comics.rb Outdated Show resolved Hide resolved
lib/faker/default/dc_comics.rb Outdated Show resolved Hide resolved
lib/faker/default/dc_comics.rb Outdated Show resolved Hide resolved
vbrazo and others added 5 commits February 15, 2020 05:09
@vbrazo @connorshea
Update lib/faker/default/dc_comics.rb
6752be4 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@vbrazo @connorshea
Update lib/faker/default/dc_comics.rb
02873cf 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@vbrazo @connorshea
Update lib/faker/default/dc_comics.rb
22e3074 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@vbrazo @connorshea
Update lib/faker/default/dc_comics.rb
86749b6 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@vbrazo @connorshea
Update lib/faker/default/dc_comics.rb
90d0b62 
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
vbrazo
vbrazo approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks 👍

@vbrazo vbrazo merged commit 24eff8d into faker-ruby:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorshea connorshea connorshea requested changes

@vbrazo vbrazo vbrazo approved these changes

Assignees

@ashelangovan ashelangovan

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashelangovan @vbrazo @connorshea