Add Rake task for creating an autogenerated rbi #1936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorshea
force-pushed
the
autogenerate-rbi
branch
from
b6f1c95
to
1af27c0
Compare
connorshea
force-pushed
the
autogenerate-rbi
branch
from
03bcd3f
to
3b61002
Compare
connorshea
added a commit
to connorshea/sorbet-typed
that referenced
this pull request
May 31, 2020
Built with Sord, from this PR: faker-ruby/faker#1936
elliottt
pushed a commit
to sorbet/sorbet-typed
that referenced
this pull request
Jun 2, 2020
Built with Sord, from this PR: faker-ruby/faker#1936
connorshea
force-pushed
the
autogenerate-rbi
branch
from
1b7e69b
to
f438e11
Compare
And update the sord rake task to handle another edge case.
connorshea
force-pushed
the
autogenerate-rbi
branch
from
682ee91
to
8389766
Compare
The constant doesn't get output in the RBI, which means that its usage as the default parameter value is invalid.
|
Hey there. In an effort to lighten our load as maintainers and be able to serve you better in the future, the faker-ruby team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this PR. Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised. If you feel that we should reopen this PR, please do the following first:
Then please let us know so that we can re-prioritize it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1854
Description:
This is a WIP PR. It also includes commits from #1853 and #1935.
I'm using the same system as I did in December (described in this gist) and it still works perfectly fine, so I'm comfortable recommending it now.
The Sord generator isn't perfect, so this requires a few workarounds to fix some invalid code within the generated RBI, that's all handled in the Sord Rake task.
I'll work on getting a new Sord release out so we can add it as a development dependency in the gemspec rather than a dependency in the Gemfile itself.
If you'd prefer not to have to maintain this as part of the gem, I'm fine with that and I can add it to sorbet-typed instead. This is mostly an experiment to see if autogenerated types like this are viable.
See the Sorbet docs on RBIs within gems.