adding Pearl Jam to the Music module #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for the Pull Request. Thanks! |
|
absolutely. I knew I forgot something :) |
lucasqueiroz
approved these changes
Apr 13, 2020
Zeragamba
suggested changes
May 19, 2020
lib/faker/music/pearl_jam.rb
Outdated
| # @example | ||
| # Faker::Music::PearlJam.musician #=> "Eddie Vedder" | ||
| # | ||
| # @faker.version 1.9.2 |
There was a problem hiding this comment.
faker version should be next for new generators
lib/locales/en/pearl_jam.yml
Outdated
Comment on lines
4
to
13
| musicians: [ "Boom Gaspar", | ||
| "Dave Abbruzzese", | ||
| "Dave Krusen", | ||
| "Eddie Vedder", | ||
| "Jack Irons", | ||
| "Jeff Ament", | ||
| "Matt Cameron", | ||
| "Matt Chamberlain", | ||
| "Mike McCready", | ||
| "Stone Gossard" ] |
There was a problem hiding this comment.
We would prefer the dash syntax for an array of values. (See CONTRIBUTING.md)
|
ok. updated the version reference and the yams syntax. Apologies, I based the original PR off of some existing code rather than referencing the contributing docs. |
Zeragamba
approved these changes
May 20, 2020
|
Perfect 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Pearl Jam to the Music module
Description:
New
Faker::Music::PearlJamclass that contains the following methods:musician- will return the name of a band member (former or current)album- will return the name of one of the band's albumssong- will return the name of one of their songs