Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Phish Albums and Musicians #2024

Merged
merged 9 commits into from
May 31, 2020
Merged

Added Phish Albums and Musicians #2024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a64224e
added phish players and albums
May 30, 2020
b7a9a3d
updated phish readme
May 30, 2020
b8f8f1b
added new tests
May 30, 2020
2bbc470
added new methods with documentation
May 30, 2020
b761ab4
updated phish yml to preferred formatting
May 30, 2020
f2a87a1
updated phish doc
May 30, 2020
85cea81
new phish albums and musicians
May 30, 2020
7e253e4
fixed comment for phish musician
May 30, 2020
6cdf21c
updated version to next
May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/music/phish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Faker::Music::Phish

```ruby
Faker::Music::Phish.album #=> "Fuego"

Faker::Music::Phish.musician #=> "Trey Anastasio"

Faker::Music::Phish.song #=> "Tweezer"
```
28 changes: 27 additions & 1 deletion lib/faker/music/phish.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,32 @@ module Faker
class Music
class Phish < Base
class << self
##
# Produces the name of a album by Phish.
#
# @return [String]
#
# @example
# Faker::Music::Phish.album #=> "Fuego"
#
# @faker.version next
def album
fetch('phish.albums')
end

##
# Produces the name of a musician in Phish.
#
# @return [String]
#
# @example
# Faker::Music::Phish.musician #=> "Trey Anastasio"
#
# @faker.version next
def musician
fetch('phish.musicians')
end

##
# Produces the name of a song by Phish.
#
Expand All @@ -14,7 +40,7 @@ class << self
#
# @faker.version 1.9.2
def song
fetch('phish.song')
fetch('phish.songs')
end
end
end
Expand Down
Loading