Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::TvShows::Suits #2025

Merged
merged 3 commits into from
May 31, 2020
Merged

Conversation

ashelangovan
Copy link

@ashelangovan ashelangovan commented May 30, 2020

Added characters and quotes for Suits TV Show.

Duplicate of #1888.

Signed-off-by: Aswin Muthu Kumar <ashelangovan97@gmail.com>
@ashelangovan
Copy link
Author

@Zeragamba can you take a look into this?

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Aswin Muthu Kumar <ashelangovan97@gmail.com>
lib/faker/tv_shows/suits.rb Outdated Show resolved Hide resolved
lib/faker/tv_shows/suits.rb Outdated Show resolved Hide resolved
Signed-off-by: Aswin Muthu Kumar <ashelangovan97@gmail.com>
@ashelangovan
Copy link
Author

@koic review changes are done.

@Zeragamba Zeragamba merged commit e9f6c4f into faker-ruby:master May 31, 2020
@Zeragamba
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants