-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2091 faker drones #2096
Merged
Merged
2091 faker drones #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeeptarlekar
force-pushed
the
2091-faker-drones
branch
2 times, most recently
from
July 31, 2020 14:28
02e4fc8
to
7fe4436
Compare
sudeeptarlekar
force-pushed
the
2091-faker-drones
branch
2 times, most recently
from
August 2, 2020 08:22
af75ae5
to
1221863
Compare
psibi
reviewed
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from a minor comment.
psibi
reviewed
Aug 7, 2020
@psibi thanks for review, resolved PR comments. Please take a look again. |
sudeeptarlekar
force-pushed
the
2091-faker-drones
branch
from
August 8, 2020 06:00
d8192d5
to
17e57f1
Compare
lucasqueiroz
reviewed
Aug 8, 2020
@lucasqueiroz thanks for review, updated units, please take a look again. |
lucasqueiroz
approved these changes
Aug 8, 2020
@psibi, @Zeragamba can we get this merged? |
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
resolves #2091
Description:
*Added drones in faker. *