Add Clash Of Clans to the Game category #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmai0512
force-pushed
the
clash_of_clans
branch
from
044b445 to
765ac9a
Compare
Zeragamba
reviewed
Oct 10, 2020
doc/games/clash_of_clans.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Faker::Games::ClashOfClans | |||
|
|
|||
| Available since version 1.8.0. | |||
There was a problem hiding this comment.
This is a new generator... wait. are you a time traveler?
There was a problem hiding this comment.
Line needs to be removed
lib/faker/games/clash_of_clans.rb
Outdated
| class ClashOfClans < Base | ||
| class << self | ||
| ## | ||
| # Produces the name of a Troops from Clash Of Clans. |
There was a problem hiding this comment.
odd english, should be Produces the name of a troop from Clash of Clans
Zeragamba
suggested changes
Oct 10, 2020
doc/games/clash_of_clans.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Faker::Games::ClashOfClans | |||
|
|
|||
| Available since version 1.8.0. | |||
There was a problem hiding this comment.
Line needs to be removed
Zeragamba
approved these changes
Oct 10, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add Conan to the JapaneseMedia category * Updated README * Fix the clash_of_clan yaml file * Changed the english mistake in clash_of_clans.md file * Removed the line
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit fc9bd02.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit fc9bd02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription: