Add a new sports section for mountaineers #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
No-StoryDescription:
I added a new generator that picks from a list of accomplished mountaineers. For now it's a short list but can be expanded. The idea for it came from my personal love for mountaineering and felt like adding a section for this sport would be a fun/good addition.
This could/would be used in any potential app ideas that relate to the mountaineering sport to provide a more realistic context in demo environments. This could pair nicely with the
Faker::Mountaingenerator 😄Generator:
Faker::Sports::Mountaineering.mountaineer=>Junko Tabei/test/faker/sports/test_faker_mountaineering.rband successfully run locally/doc/sports/mountaineering.rb/lib/faker/sports/mountaineering.rb/lib/locales/en/mountaineering.yml