fix: ensure generated passwords have correct characters when mixed_case & special_characters enabled #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiff-o
force-pushed
the
fix/password-with-mixed-case-and-special-chars
branch
from
6a112e4
to
5eb00cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when mixed_case and special_characters were enabled, the generated password would sometimes exclude the mixed_case characters because they were being overwritten by special characters instead.
This PR ensures that when mixed_case and special_characters are both true (unless the generated password length is not enough to include all), the generated password includes at least:
Should the generated password not allow for this (e.g. generated password length is 1), then ensure that special characters take priority over letters and numbers.
Fixes Issue #2512
Other Information