Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehicle version generator #2540

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

trinaldi
Copy link
Contributor

Summary

I opened PR #2539 thinking we didn't have this kind of generator. However, I've noticed that we currently don't have a Vehicle.version generator, so I decided to make my contribution.

From AutoTrader

What is a version of a car?
A variant is the label that is used to describe a particular vehicle. Rather than just having the make and model, it includes more specific data such as engine size, number of doors and the version. E.g. Ford Fiesta (1.25 Zetec Hatchback 5dr)

In this case 1.25 Zetec Hatchback 5dr is the version.

Other Information

Use example in addition to other generators:

Faker::Vehicle.manufacture
"Subaru"

Faker::Vehicle.model
"Navigator"

Faker::Vehicle.version
"Limited T270 1.3 TB"

lib/locales/en/vehicle.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have prefered if it was just the new section, but this does help

Just noticed this typo
# Random vehicle version
Faker::Vehicle.version #=> "2.5 Turbo"

Faker::Vehicle.version #=> "Altis Hybrid 1.8 16V CVT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at that and thought it was odd too :P

@Zeragamba Zeragamba merged commit 9093f59 into faker-ruby:master Aug 26, 2022
@trinaldi trinaldi deleted the add-vehicle-version-generator branch August 26, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants