Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computer test #2543

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Conversation

trinaldi
Copy link
Contributor

Summary

This PR is one fix for #2541

Other Information

According to the YAML Specification, spaces are allowed in keys. I changed from plannine to plan 9 to match the available stacks and improved the matcher (regex) in the test.

As always, open to suggestions.

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stefannibrasil stefannibrasil linked an issue Aug 28, 2022 that may be closed by this pull request
@stefannibrasil stefannibrasil merged commit aaf6cbe into faker-ruby:master Aug 28, 2022
@trinaldi trinaldi deleted the fix-computer-test branch August 28, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test: test_stack on test_faker_computer.rb
2 participants