Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fma_brotherhood usage example #2552

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fix fma_brotherhood usage example #2552

merged 1 commit into from
Sep 1, 2022

Conversation

y0n0zawa
Copy link
Contributor

@y0n0zawa y0n0zawa commented Sep 1, 2022

Summary

The usage example written in the readme was wrong, so I fixed it.

pry(main)> Faker::JapaneseMedia.fma_brotherhood.country
NoMethodError: undefined method `fma_brotherhood' for Faker::JapaneseMedia:Class

pry(main)> Faker::JapaneseMedia::FmaBrotherhood.country
=> "Aerugo"

vbrazo
vbrazo approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks ❤️

@vbrazo vbrazo merged commit 7a922fd into faker-ruby:master Sep 1, 2022
@y0n0zawa y0n0zawa deleted the patch-1 branch September 15, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y0n0zawa @vbrazo