Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clojure as a language option to Faker::Source generator #2582

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Add clojure as a language option to Faker::Source generator #2582

merged 2 commits into from
Oct 6, 2022

Conversation

professorjrod
Copy link
Contributor

PS This is my first open source contribution

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this, and welcome!

I left one suggestion.

lib/locales/en/source.yml Outdated Show resolved Hide resolved
Co-authored-by: Thiago Araujo <thd.araujo@gmail.com>
@thdaraujo thdaraujo changed the title I added clojure to the source Add clojure as a language option to Faker::Source generator Oct 6, 2022
Copy link
Contributor Author

@professorjrod professorjrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to make it consistent with the rest of the file since all of the the other languages use print.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thdaraujo thdaraujo merged commit 5e07866 into faker-ruby:main Oct 6, 2022
sudeeptarlekar pushed a commit to sudeeptarlekar/faker that referenced this pull request Oct 7, 2022
…r-ruby#2582)

* I added clojure to the source

* Update lib/locales/en/source.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Lisp dialect option and examples to Faker::Source generator
2 participants