Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes NBSP from locales files #2596

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

hbontempo-br
Copy link
Contributor

Summary

Removes NBSP character from locales files.
This can result in a response different than the expected.

Example:
The patter expected for Faker::Sports::Football.player in the test test_es_ar_football_player (at test/test_es_ar_locale.rb) does not currently apply for the player 'Darío[NBST]Benedetto'

Other Information

Through a local IDE interface the difference is more clear
image

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@thdaraujo thdaraujo merged commit a698061 into faker-ruby:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants