Fix: ensure sport generator produces single sport unless a number of sports is requested #2616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #2608
there was a bug that resulted in
Faker::Sport.sport(include_ancient: true)
generating an array of sports instead of a single sport.The problem was caused by this line.
When using << to add ancient_olympics sports to the
sports
array we were creating a nested array that looked like that:So once in a while, this last element was picked by the
.sample
method and caused the problem.I changed the sport method to use concat method to combine arrays correctly.
Other Information