Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove english characters in ja locale file, fixes faker-ruby#2637 #2638

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove english characters in ja locale file, fixes faker-ruby#2637 #2638

merged 1 commit into from
Nov 30, 2022

Conversation

alextaujenis
Copy link
Contributor

Summary

  • This PR fixes issue Random spec failing: Failure: test_ja_supermario_methods(TestJaLocale) #2637
  • The test validates that all Faker::Games::SuperMario.character in the ja locale are NOT in English.
  • One of the Super Mario Characters is named クッパJr. (translated Bowser Jr.), which includes the English characters Jr. at the end.
  • Just removing the Jr. from the end of the name in this file will produce a duplicate result of クッパ (which is already present in the file).
  • クッパJr. has been removed from the list of Super Mario Characters in the ja locale to satisfy the test that verifies that all Faker::Games::SuperMario.character in the ja locale are NOT in English.

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefannibrasil stefannibrasil merged commit 1c28402 into faker-ruby:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants