Fix country code length for non EN locale #2669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Faker::Address.country_code follows the ISO country code country codes.
All locale files should use the
en/address.yml
forcountry_code
to get the country code, regardless of whatFaker::Config.locale
is set.How
Remove the
country_code
key from the non-EN locale files. Now, all locales will default thecountry_code
to theen.address.yml
, which follows the ISO 3166 standard.Closes #2646.