Speed up Internet::Password generation using constants #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MicBruz thank you for your interest in helping Faker! Unfortunately, this generator does not have a reliable test suite, IMO. The changes here make sense but I'm a bit hesitant to merge it as I don't trust the tests to catch any bugs as new changes are introduced. Would you be interested in improving the tests for this generator first? I've added a comment here #2704 (comment) Thanks! |
thdaraujo
reviewed
Apr 18, 2023
| password << upper_chars[rand(upper_chars.count - 1)] | ||
| if mix_case | ||
| upper_chars = self::ULetters | ||
| password << sample(upper_chars) |
MicBruz
commented
Apr 29, 2023
| character_bag += lower_chars | ||
|
|
||
| digits = ('0'..'9').to_a | ||
| password << digits[rand(digits.count - 1)] | ||
| password << sample(digits) |
There was a problem hiding this comment.
Digits appeared here so I have also adjusted that line.
There was a problem hiding this comment.
Yeah, this a bug fix 🐞
|
@stefannibrasil done! Thank you for the patience and sorry for the delay :( |
stefannibrasil
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When reviewing #2705, I found out that there is a way to speed up password generation for Faker::Internet by more than 30% (benchmarks below). Instead of creating a new array with desired characters every time, we can use constants already defined in Faker::Base.
Also, to improve readability, I've changed [rand(special_chars.count - 1)] with a predefined sample() method and shortened if statements to base on parameters.
I changed a minimal required password length to the first password test since the default min. length is 8 (not 3)
Other Information
Benchmark I've run:
Before the change I've got:
3.272090 0.010629 3.282719 ( 3.282693)After the change I've got:
2.179874 0.005755 2.185629 ( 2.185604)That is my first PR. I followed the guide, however, if I missed something, I am sorry!