Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_country_code in locale #2732

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add default_country_code in locale #2732

merged 1 commit into from
Mar 23, 2023

Conversation

ashwin-elangovan
Copy link
Contributor

Summary

Was looking into #2684 and it was mentioned that default_country_code must be added. So added it to the other missing locales.

@ashwin-elangovan ashwin-elangovan mentioned this pull request Mar 18, 2023
Closed
psibi
psibi approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will also let @stefannibrasil take a look.

stefannibrasil
stefannibrasil approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you so much for the help! 🎉

@stefannibrasil stefannibrasil merged commit 4d52bc1 into faker-ruby:main Mar 23, 2023
@stefannibrasil
Copy link
Contributor

Just a quick note for future PRs: if you add "close issue #2732" or "fix issue #2732", GitHub closes the issue automatically. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

@psibi psibi psibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashwin-elangovan @stefannibrasil @psibi