Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pull Request template and guides #2749

Merged

Conversation

stefannibrasil
Copy link
Contributor

@stefannibrasil stefannibrasil commented Apr 14, 2023

Summary

It's easy to forget more details, review the docs when opening a PR. To help everyone, I'm updating the PR template and its reference to the documentation guidelines.

Also, we don't have a code of conduct yet, but having a guideline about language is a start.

It's easy to forget more details, review the docs when
opening a PR. To help everyone, I'm updating the PR template
and its reference to the documentation guidelines.
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 2 suggestions

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@stefannibrasil stefannibrasil merged commit 949661c into faker-ruby:main Apr 14, 2023
@stefannibrasil stefannibrasil deleted the sb-update-pr-template-and-docs branch April 14, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants