Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken chars from minecraft.yml #2765

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

ujihisa
Copy link
Contributor

@ujihisa ujihisa commented May 25, 2023

Motivation / Background

I found that when I use Faker::Games::Minecraft.status_effect the strings given from it sometimes had something weird at the end.

Found that the yml had a unicode character <200c> and space(s) at the end:
Screenshot_2023-05-25_16-00-33

This Pull Request has been created because these need to be truncated.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [N/A] Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@thdaraujo thdaraujo merged commit 2338550 into faker-ruby:main May 26, 2023
@ujihisa ujihisa deleted the patch-1 branch May 26, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants