Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve de-CH locale with new formats and content #2768

Merged
merged 3 commits into from
May 31, 2023

Conversation

stefnnn
Copy link
Contributor

@stefnnn stefnnn commented May 28, 2023

Motivation / Background

The current Swiss German (de-CH) locale is quite outdated and many US defaults are used. There is no fallback to the "de" locale, which might be a consideration at some point.

Additional information

I reformatted the YAML file to conform to the dashed-single-line format.

Checklist

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

lib/locales/de-CH.yml Outdated Show resolved Hide resolved
lib/locales/de-CH.yml Outdated Show resolved Hide resolved
@stefnnn stefnnn requested a review from psibi May 29, 2023 06:21
lib/locales/de-CH.yml Outdated Show resolved Hide resolved
@psibi psibi merged commit a9fcec8 into faker-ruby:main May 31, 2023
@psibi
Copy link
Member

psibi commented May 31, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants