Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky specs for name and id #2782

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Fix flaky specs for name and id #2782

merged 1 commit into from
Jun 19, 2023

Conversation

ruban-thilak
Copy link
Contributor

Motivation / Background

This Pull Request has been created because [REPLACE ME]

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@ruban-thilak ruban-thilak mentioned this pull request Jun 18, 2023
Merged
4 tasks
thdaraujo
thdaraujo approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you for fixing this!

@thdaraujo thdaraujo changed the title [Fix #2772] - Flaky specs Fix flaky specs for name and id Jun 19, 2023
@thdaraujo thdaraujo merged commit 7ac1c37 into faker-ruby:main Jun 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruban-thilak @thdaraujo