Fix country names and codes in address #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sweet! What do you think of taking this opportunity to also format this file by running bundle exec rake reformat_yaml['lib/path/to/file.yml']?
Few countries changed their name and this PR updates those names from old ones to new ones. Also refactored some code in address.yml file for consistency. Resolves: faker-ruby#2848
sudeeptarlekar
force-pushed
the
2848-country-names
branch
from
617e209
to
2a4a9d8
Compare
|
@stefannibrasil Made a requested changes, please review again.... Thanks in advance |
stefannibrasil
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Few countries changed their name and this PR updates those names from old ones to new ones.
Also refactored some code in address.yml file for consistency.
Resolves: #2848