Add benchmark #2855
Merged
Add benchmark #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add benchmark rake task for evaluating time execution. Fixes Co-authored-by: Rubens Fernandes <rubens.fernandes97@gmail.com>
thdaraujo
reviewed
Nov 20, 2023
thdaraujo
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Excellent contribution, thanks for working on this!
This is a great first step to help us improve the performance of the gem. 🙏
Thanks @salochara and @okaydokay97 for working on this!
I just left one suggestion, let me know what you think.
- Build all_methods outside the benchmark since we don't want to measure that.
salochara
force-pushed
the
feature/add-benchmark
branch
from
f531b8e
to
3fb283e
Compare
|
Hi @thdaraujo ! This is looking good! Probably we can create an "issue" here on GH have a simple draft on next steps, things to do. Would love to keep on contributing ! All the best! 🙏🏼 |
- Avoid calling the same object twice
|
Done! ✅ Awesome... I'll have a look at it whenever I get a chance. |
stefannibrasil
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #2851
In this PR, @okaydokay97 and I are adding a rake task to run a benchmark on every Faker generator!
Here's a screenshot of the results:
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]