Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo for README. Faker::JapaneseMedia::CowboyBebop #2863

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fixed typo for README. Faker::JapaneseMedia::CowboyBebop #2863

merged 1 commit into from
Dec 8, 2023

Conversation

jacoyutorius
Copy link
Contributor

@jacoyutorius jacoyutorius commented Dec 2, 2023 •
edited
Loading

Motivation / Background

This is a minor fix. I found typo in README.
(because I am a huge fun of CowboyBebop!)

- Faker::JapaneseMedia::CowboyBebop.songs
+ Faker::JapaneseMedia::CowboyBebop.song

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@jacoyutorius
fixed typo for README Faker::JapaneseMedia::CowboyBebop
4655e36 
Faker::JapaneseMedia::CowboyBebop.songs => Faker::JapaneseMedia::CowboyBebop.song
@jacoyutorius jacoyutorius marked this pull request as ready for review December 2, 2023 01:28
stefannibrasil
stefannibrasil approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefannibrasil stefannibrasil merged commit 3c45ee7 into faker-ruby:main Dec 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefannibrasil stefannibrasil stefannibrasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacoyutorius @stefannibrasil